-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: support webhook.enablePolicyApi #9632
Conversation
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit e11b75d): https://gloo-edge--pr9632-sam-helm-policy-vali-2fepd0ij.web.app (expires Tue, 25 Jun 2024 19:00:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than 1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this means an invlaid order could break a non-k8s gateway resource apply but it seems that is ok in this case.
Therefore approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but found a nit on the new addition to the doc string
* update helm api and docs * bad . * more restrictive check * add test case * add changelog * undo debugging step * update helm api description * improve helm description --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* iosnapshot/history: fix test flake (#9630) * fix test flake * add changelog * skip kube tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * helm: support webhook.enablePolicyApi (#9632) * update helm api and docs * bad . * more restrictive check * add test case * add changelog * undo debugging step * update helm api description * improve helm description --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * introduce test coverage reporting, update devel with Gloo Gateway references (#9646) * devel/ : Gloo Edge -> Gloo Gateway * more changes * update workflows, add go-test-with-coverage * run unit tests on PR * update name * fix coverage file path * consistent step names * disable race to prove out test coverage * add working dir * properly specify outputdir * test coverage update * install test tools * install tools and coverage tools * update thresholds, ignore errors in CI * update test coverage def * add changleog * update commet in gha * re-add race flag * E.T phone home * Apply suggestions from code review Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Apply suggestions from code review Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> * more suggestions * skip kube tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> * consolidate changelog * gateway2/deployer: fix race due to context cancellation (#9651) * fix helm race * tidy * update commentary, and function asignautres --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * cleanup changelog * delete readme, was moved to devel folder --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com>
Description
Introduce new Helm API:
gateway.validation.webhook.enablePolicyApi
Context
See https://github.com/solo-io/solo-projects/issues/6321 and https://github.com/solo-io/solo-projects/issues/6251 for context around a race condition that exists in the validation webhook.
Due to this race, we need a way for users to explore and use the Kubernetes Gateway Integration, but also opt-out of validation (in case the race condition is preventing resources from being updated)
Interesting decisions
Testing steps
Notes for reviewers
Checklist: